bots/collectors/api: make socket file permissions configurable #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-certat
requested changes
Oct 24, 2023
|
Good change, as @kamil-certat said. With docs, it would be good to merge. |
sebix
added
component: bots
feature
|
Done. Apologies for the delay |
kamil-certat
approved these changes
Oct 31, 2023
|
@monoidic In the meantime, we have changed the documentation system. May you merge develop and move your docs changes to the docs/user/bots.md? |
sebix
force-pushed
the
api_socket_perms
branch
from
ac33d8d
to
0fc3d6c
Compare
|
I fixed the merge errors (some unrelated changes were part of the PR's commits), now ready for merge after the CI checks pass. |
|
Merging, as reviewed OK by @kamil-certat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
tornado.netutil.bind_unix_socketcreates socket files with600permissions and which have the owner and group of the creating user (intelmq). This does not work well in the common case of the process at the other end of the socket not being a process running as the intelmq user.This commit adds
socket_permsandsocket_groupconfiguration parameters to the bot to allow for the file's permissions to be changed.